Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MintValue #6609

Merged
merged 3 commits into from
Oct 31, 2024
Merged

MintValue #6609

merged 3 commits into from
Oct 31, 2024
+292 −39

Conversation

Unisay
Copy link
Contributor

@Unisay Unisay commented Oct 29, 2024 •
edited
Loading

Closes #6445

Pre-submit checklist:

  • Branch
    • Tests are provided (if possible)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Changelog fragments have been written (if appropriate)
    • Relevant tickets are mentioned in commit messages
    • Formatting, PNG optimization, etc. are updated
  • PR
    • (For external contributions) Corresponding issue exists and is linked in the description
    • Targeting master unless this is a cherry-pick backport
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

@Unisay Unisay self-assigned this Oct 29, 2024
@Unisay Unisay mentioned this pull request Oct 29, 2024
Closed
@Unisay Unisay requested review from zliu41 and a team October 30, 2024 17:41
@Unisay Unisay marked this pull request as ready for review October 30, 2024 17:42
@Unisay Unisay enabled auto-merge (squash) October 31, 2024 16:22
ana-pantilie
ana-pantilie approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@ana-pantilie ana-pantilie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the discussion about testing!

Will a subsequent PR also implement a data-backed version of MintValue? I think that will be necessary in order to provide a fully data-backed ScriptContext to users.

@Unisay Unisay merged commit 373de94 into master Oct 31, 2024
8 checks passed
@Unisay Unisay deleted the yura/mint-value branch October 31, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ana-pantilie ana-pantilie ana-pantilie approved these changes

@zliu41 zliu41 Awaiting requested review from zliu41

Assignees

@Unisay Unisay

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a newtype for Value to represented minted/burned tokens
2 participants
@Unisay @ana-pantilie