Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use taskset in ci-plutu-benchmark.sh #6646

Merged
merged 1 commit into from
Nov 10, 2024
Merged

Use taskset in ci-plutu-benchmark.sh #6646

merged 1 commit into from
Nov 10, 2024

Conversation

zeme-wana
Copy link
Contributor

@zeme-wana zeme-wana commented Nov 9, 2024

You can now run
/benchmark BENCH_NAME cap=CAPABILITY_NUM
In addition to
/benchmark BENCH_NAME

The former will run BENCH_NAME on the given CPU core

@kwxm kwxm added Benchmarks No Changelog Required Add this to skip the Changelog Check labels Nov 9, 2024
@kwxm kwxm self-requested a review November 9, 2024 19:24
Copy link
Contributor

@kwxm kwxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks.

@@ -36,6 +39,13 @@ else
git checkout "$PR_BRANCH"
fi

if [ -z "$CAPABILITY_NUM" ] ; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any way of setting this from GitHub?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easiest way would be to:
/benchmark BENCH_NAME CAP_NUM
Instead of
/benchmark BENCH_NAME
Sounds good?

@kwxm kwxm enabled auto-merge (squash) November 9, 2024 19:26
@zeme-wana zeme-wana changed the title Upse taskset in ci-plutu-benchmark.sh Use taskset in ci-plutu-benchmark.sh Nov 9, 2024
@kwxm kwxm disabled auto-merge November 10, 2024 09:14
@kwxm
Copy link
Contributor

kwxm commented Nov 10, 2024

Hydra seems to be broken, so I'm going to ignore it and merge this anyway.

@kwxm kwxm merged commit 085b74b into master Nov 10, 2024
5 of 7 checks passed
@kwxm kwxm deleted the taskset-for-benchmark branch November 10, 2024 09:15
@kwxm kwxm mentioned this pull request Nov 10, 2024
@@ -55,8 +65,14 @@ cabal update
echo "[ci-plutus-benchmark]: Clearing caches with cabal clean ..."
cabal clean

if [[ -z $(which taskset) ]]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wait: I think that should be -n. I'll open a quick PR to fix that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Benchmarks No Changelog Required Add this to skip the Changelog Check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants