-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use taskset in ci-plutu-benchmark.sh #6646
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks.
@@ -36,6 +39,13 @@ else | |||
git checkout "$PR_BRANCH" | |||
fi | |||
|
|||
if [ -z "$CAPABILITY_NUM" ] ; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any way of setting this from GitHub?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Easiest way would be to:
/benchmark BENCH_NAME CAP_NUM
Instead of
/benchmark BENCH_NAME
Sounds good?
Hydra seems to be broken, so I'm going to ignore it and merge this anyway. |
@@ -55,8 +65,14 @@ cabal update | |||
echo "[ci-plutus-benchmark]: Clearing caches with cabal clean ..." | |||
cabal clean | |||
|
|||
if [[ -z $(which taskset) ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh wait: I think that should be -n
. I'll open a quick PR to fix that.
You can now run
/benchmark BENCH_NAME cap=CAPABILITY_NUM
In addition to
/benchmark BENCH_NAME
The former will run BENCH_NAME on the given CPU core