Bug in using argparse and multiple repetition of default values #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the script I noticed that there was a bug in the commit automation script checking. The parameters had been reversed. Also, the commit flag, so to speak, the -g had wrong parameters that forced it to have an argument. Furthermore, as explained in the issue, there is a need to change the readme, as it is incorrectly recommended to use the script. I recommend the following change: python yt_crawl.py -a "API_KEY_HERE" -g
|
Checking the sources, I think it is also useless to keep the yt_data.py file, as it appears to be an outdated version of this file. I also recommend updating the json file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the script I noticed that there was a bug in the commit automation script checking. The parameters had been reversed. Also, the commit flag, so to speak, the -g had wrong parameters that forced it to have an argument.
Furthermore, as explained in the issue, there is a need to change the readme, as it is incorrectly recommended to use the script. I recommend the following change:
python yt_crawl.py -a "API_KEY_HERE" -g