remove scaffolding for settings.php

[joshdentremont]

Fix for Islandora-Devops/isle-dc#306

Scaffolding settings.php causes issues because settings.php is not writable. The patch is meant to set the sync directory in settings.php, but this is done already when the site is installed via Isle, so the patch is not necessary.

This fix solves the above issue for Isle, but may result in the config directory not being set in non-Isle installs like the playbook or a manual install.

[joshdentremont]

This can be tested by doing a fresh install in Isle of make starter then running composer updates. Without this PR those updates will throw an error that settings.php is not writable. WIth this PR it should complete the update successfully.

It should also be tested in a non Isle install to make sure that the config directory is still being set correctly. The above issue would likely affect other installs where settings.php is not writable, so if we need to add that config directory in the playbook install it should probably be done as part of the vagrant install instead of via Drupal scaffolding.

[rosiel]

This touches:

• documentation (in the starter site's README, for starters)
• islandora playbook
• isle-site-template
• the online sandbox
• manual instructions (though they are very old and out of date)

I think a change like this would be an "API breaking change" and thus result in a new major version of the Starter Site. Existing sites would (should!) need to change the version spec in order to get this change.

I think it might be worth asking whether there's any other way the starter site could, on its own, set its own config directory - since it is what's providing the contents and directory of config/sync. If you are using the starter site, there is nothing else that you would want this value set to. We are trying to make the starter site self-contained and independent of what's used to install it.

[joshdentremont]

Closed due to causing issues for non-Isle installs