Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update alpine/drush launcher. #285

Merged
merged 2 commits into from
Aug 15, 2023
Merged

Update alpine/drush launcher. #285

merged 2 commits into from
Aug 15, 2023

Conversation

nigelgbanks
Copy link
Contributor

Just some house keeping, needs testing.

@rosiel
Copy link
Contributor

rosiel commented Aug 11, 2023

Testing log:

  1. download this PR in buildkit. Ran docker buildx bake to create all the images locally. (make bake failed, not sure why)
  2. set up a new isle-site-template using the automatic method. Edit .env and change ISLANDORA_TAG from main to local. Also changed the site name to test-drush.
  3. build the drupal container and start the containers using the commands in README.template.md.

Result:
drupal container failed and exited.

Note: I think the testing was legit despite me not knowing what i'm doing, because the image used by the drupal container, named islandora.io/test-drush:local includes, in its layers, drush version 0.10.2.

The problem I think is that drush launcher doesn't work with drush 12, which is what i'm trying to install with the starter site because it's the only one that's not facing down EOL in the next few months.

@rosiel
Copy link
Contributor

rosiel commented Aug 11, 2023

That said, I re-tested with 0.8.0 and it works great. drush runs in the ide. So this is a good bit of housekeeping though the launcher part is still a problem. Mind if i merge?

@rosiel rosiel merged commit e4883dc into main Aug 15, 2023
76 checks passed
@rosiel rosiel deleted the update-alpine branch August 17, 2023 12:42
g7morris pushed a commit to Born-Digital-US/isle-buildkit that referenced this pull request Sep 1, 2023
* Upgrade Alpine to latest release

* Upgrade drush launcher
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants