Issue 309 - Adding transaction isolation and default to read committed #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nigelgbanks
requested changes
Dec 1, 2023
mariadb/Dockerfile
Outdated
| ENV \ | ||
| # Default Mariadb value of 16 MB (bytes) | ||
| MYSQL_MAX_ALLOWED_PACKET=16777216 \ | ||
| TRANSACTION_ISOLATION=READ-COMMITTED |
There was a problem hiding this comment.
Please prefix TRANSACTION_ISOLATION with MYSQL to be consistent with the environmental naming conventions across the repository.
So MYSQL_TRANSACTION_ISOLATION.
mariadb/README.md
Outdated
| @@ -41,7 +41,8 @@ default database connection configuration. | |||
| | :------------------- | :------ | :------------------------------------------------------------------------------------ | | |||
| | MYSQL_ROOT_PASSWORD | | The database root user password. Defaults to `DB_ROOT_PASSWORD` | | |||
| | MYSQL_ROOT_USER | | The database root user (used to create the site database). Defaults to `DB_ROOT_USER` | | |||
| | MYSQL_MAX_ALLOWED_PACKET | 16777216 | Max packet length to send to or receive from the server, [documentation](https://mariadb.com/docs/server/ref/mdb/system-variables/max_allowed_packet/) | | |||
| | MYSQL_MAX_ALLOWED_PACKET | 16777216 | Max packet length to send to or receive from the server, [documentation](https://mariadb.com/docs/server/ref/mdb/system-variables/max_allowed_packet/) | |||
| | TRANSACTION_ISOLATION | READ-COMMITTED | The isolation level for transactions. | |||
There was a problem hiding this comment.
Same prefix note as above, and please link to the documentation.
https://mariadb.com/docs/server/ref/mdb/system-variables/transaction_isolation/
| @@ -9,6 +9,7 @@ | |||
| [mysqld] | |||
| # skip-networking | |||
| max_allowed_packet ={{ getenv "MYSQL_MAX_ALLOWED_PACKET" }} | |||
| transaction-isolation ={{ getenv "TRANSACTION_ISOLATION" }} | |||
There was a problem hiding this comment.
Same prefix note as above.
|
Thank you @nigelgbanks for the feedback and for reviewing it. That makes sense to me and I made the changes that you recommended. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue #309. This adds an environment variable to the mariadb image that allows you to set the transaction isolation setting. It defaults to READ-COMMITTED now.
Related issues: Islandora/documentation#1481 and Islandora-Devops/islandora-playbook#250