-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose everything including the kitchen sink #239
base: development
Are you sure you want to change the base?
Conversation
I could not get the make target "kitchen_sink" work for me, but for now I am assuming my setup is to blame. It seems that this Line 347 in 55e71db
is evaluating as false on my macOS machine, since I am getting this output...
from the related else clause... Lines 375 to 378 in 55e71db
For the record, I ran the kitchen_sink target after I had run make local successfully. I also made sure I had a valid I wondered if there could be a permission issue to find the
I will try to test this again tomorrow after once again deleting all images, volumes, etc. to try to eliminate potential issues. Though I would not be surprised if this PR worked fine for others if they also want to test it. |
@DonRichards I tried testing this branch with the changes from today (2022-03-30) and I was not able to build make local, so I don't think I should even try to now test the Here is the last few lines before
Also, when I try to visit https://islandora.traefik.me/ I get redirected to https://islandora.traefik.me/core/install.php and see the first page of a Drupal 9 install page. For the record, I tried running Any suggestions? |
@ysuarez If you change TAG=1.0.0-alpha-15 & DRUPAL_INSTALL_PROFILE=standard in the |
@DonRichards I tried again making those I got a sed error on macOS when running Here is the
After doing some research, Making sed work with “edit in place” in BOTH unix/linux and macOS had been an issue for a while, for example this 10 year old post https://stackoverflow.com/questions/5694228/sed-in-place-flag-that-works-both-on-mac-bsd-and-linux but I got with…. |
Probably needs a better solution
20e3177
to
4aa3b96
Compare
@ysuarez It should work now on either Linux or Mac. |
Testing this today. May not be able to test with |
I am still having issues with Line 381 in 4aa3b96
|
Today at the "tech call" it was discussed that I am probably running into an issue with macOS and using the bash shell. We will need to find a workaround for macOS bash, but I will try to test again with zsh which is the macOS Big Sur's default shell. |
I tried testing again and looks like almost everything ran OK. The containers were stopped/removed. Changes were made in the My uneducated understanding is that I got errors related to line 183... Lines 182 to 183 in 10af581
These are the errors I got at the end.
Hope this helps. |
For testing, demo, documentation, etc. it's helpful to have everything on and easy to find. This adds a optional make command to expose the frontend URLs for Drupal, Traefik, Fedora, Blazegraph, Activemq, Solr, Cantaloupe, Matomo, and Code Server.
The output of running this will give the user the URLs specific to their configuration.
The help message returns the following text
To test
The assumption the user has already started isle-dc and doesn't have any or all of the items already exposed. This looks within the
.env
file and replacesfalse
totrue
for each one of the above mentioned services to expose the service.Run the following
Navigate to each one of the links it provided and verify all of the URLs work. Please note that
http
&https
are NOT interchangeable. Please use the exact URL indicated in the terminal.Also review the added documentation for clarity on how to use this make command.
Additional house cleaning