Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Template Setup Documentation #2311

Merged
merged 8 commits into from
Jun 6, 2024
Merged

Conversation

joshdentremont
Copy link
Contributor

Purpose / why

Adding extra information about setting up a site template site as described in #2302

What changes were made?

Added a new documentation page

Verification

  • Check that the instructions make sense
  • Check that the importing demo objects section works and gives you the correct demo objects

Interested Parties

  • @Islandora/documentation
  • @Islandora/committers

Checklist

Pull-request Reviewer

Pull-request reviewer should ensure the following:

Person Merging

The person merging should ensure the following:

  • Does mkdocs still build successfully? (This is indicated by TravisCI passing. To test locally, and see warnings, see How To Build Documentation.)
  • If pages are renamed or removed, have all internal links to those pages been fixed?
  • If pages are added, have they been linked to or placed in the menu?
  • Did the PR receive at least one approval from a committer, and all issues raised have been addressed?

@joshdentremont joshdentremont changed the title St setup Site Template Setup Documentation May 31, 2024
Copy link
Member

@rosiel rosiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve, but wait till @nigelgbanks gives the OK (it includes too much about production for me to be confident merging).

@nigelgbanks
Copy link
Member

I'll approve, but wait till @nigelgbanks gives the OK (it includes too much about production for me to be confident merging).

Looks good to me!

@rosiel rosiel merged commit e21fa44 into Islandora:main Jun 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants