8.2 deprecations from tests

[rosiel]

GitHub Issue: Islandora-Devops/isle-dc#356

• Other Relevant Links (Google Groups discussion, related pull requests,
  Release pull requests, etc.) the logs from the latest php 8.2 test runs have a lot of deprecations.

What does this Pull Request do?

This should remove some/all of the deprecation problems in the logs when our CI Action runs.

(note: a lot of fuss is created by Drupal Facets which is a separate issue, at the moment of writing this it's RTBC.

What's new?

• Declare two variables

• Removed one unused variable (perhaps false start?)

• Reworked how a variable was included in a string.

• Does this change add any new dependencies? no

• Does this change require any other modifications to be made to the repository
  (i.e. Regeneration activity, etc.)? no

• Could this change impact execution of existing code? shouldn't.

How should this be tested?

Wait till tests run. Then, under PHPUnit Tests for all the 8.2 runs, are there any non-Features-related deprecations listed?

Documentation Status

• Does this change existing behaviour that's currently documented? n/a
• Does this change require new pages or sections of documentation? n/a
• Who does this need to be documented for? n/a
• Associated documentation pull request(s): ___ or documentation issue ___

Additional Notes:

Any additional information that you think would be helpful when reviewing this
PR.

Interested parties

Tag (@ mention) interested parties or, if unsure, @Islandora/committers