🧪 Updated macos version and iPhone sim

Iterable · Dec 11, 2024 · 12447f6 · 12447f6
1 parent 2395405
commit 12447f6
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 5 deletions.
diff --git a/.github/workflows/build-and-test.yml b/.github/workflows/build-and-test.yml
@@ -4,7 +4,7 @@ on: pull_request
 
 jobs:
   run-tests-job:
-    runs-on: macos-13
+    runs-on: macos-14
 
     steps:
       - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
@@ -15,7 +15,7 @@ jobs:
 
       - name: Build and test
         run: |
-          xcodebuild test -project swift-sdk.xcodeproj -scheme swift-sdk -sdk iphonesimulator -destination 'platform=iOS Simulator,name=iPhone 14 Pro Max' -enableCodeCoverage YES CODE_SIGNING_REQUIRED=NO | xcpretty && exit ${PIPESTATUS[0]}
+          xcodebuild test -project swift-sdk.xcodeproj -scheme swift-sdk -sdk iphonesimulator -destination 'platform=iOS Simulator,name=iPhone 14' -enableCodeCoverage YES CODE_SIGNING_REQUIRED=NO | xcpretty && exit ${PIPESTATUS[0]}
 
       - name: CocoaPods lint
         run: pod lib lint

diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml
@@ -4,7 +4,7 @@ on: pull_request
 
 jobs:
   run-e2e-job:
-    runs-on: macos-13
+    runs-on: macos-14
 
     steps:
       - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1

diff --git a/tests/notification-extension-tests/NotificationExtensionTests.swift b/tests/notification-extension-tests/NotificationExtensionTests.swift
@@ -398,8 +398,6 @@ class NotificationExtensionTests: XCTestCase {
 
                     XCTAssertNotNil(createdCategory)
                     XCTAssertEqual(createdCategory!.actions.count, 1, "Number of buttons matched")
-                    let actionButton = createdCategory!.actions.first!
-                    XCTAssertNil(actionButton.icon)
                     expectation1.fulfill()
                 })
             }