Created ThreadSafeOrderedDictionary Wrapper #860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evantk91
changed the base branch from
master
to
feature/threadSafeOrderedDictionaryWrapper
|
merging into feature branch for review. |
evantk91
merged commit 3c18793
into
Iterable:feature/threadSafeOrderedDictionaryWrapper
0 of 2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔹 Jira Ticket(s)
✏️ Description
InAppManagercan crash as stated in this issue due toOrderedDictionarynot being thread safe. This change introducesThreadSafeOrderedDictionarywhich is a wrapper around it to ensure thread safety. To minimize changes I have introduced it only where needed. In the future it would be a good idea to look at makingOrderedDictionarysafe by itself.Tests for concurrency safety have also been added.