Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #124 #220

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

amirmalka
Copy link

Fixes an issue were collapsed rows (with panels) are skipped and not rendered.

@IzakMarais
Copy link
Owner

Thank you so much for this. Are you willing to also add a test for it?

From the code it looks like it would fit here: https://github.com/IzakMarais/reporter/blob/master/grafana/dashboard_test.go#L79

@amirmalka
Copy link
Author

I tried running the tests using "Go test" command as described in the README but getting

panic: Top-level calls to Convey(...) need a reference to the testing.T.
Hint: Convey("description here", t, func() { /
notice that the second argument was the *testing.T (t)! */ }) [recovered]
panic: Top-level calls to Convey(...) need a reference to the testing.T.
Hint: Convey("description here", t, func() { /
notice that the second argument was the *testing.T (t)! */ }) [recovered]
panic: Top-level calls to Convey(...) need a reference to the testing.T.
Hint: Convey("description here", t, func() { /
notice that the second argument was the *testing.T (t)! */ })

Any idea?

@IzakMarais
Copy link
Owner

Sorry for the slow turnaround time.

I will need to schedule some time to take a look at this.

FaksBoi added a commit to FaksBoi/reporter-jarvis that referenced this pull request May 29, 2021
Popravek nepravilnega renderiranja. 
Napaka:IzakMarais#124
Rešitev: IzakMarais#220
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants