Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ip to 4.1.0 #294

Conversation

AlexanderRichert-NOAA
Copy link
Collaborator

@AlexanderRichert-NOAA AlexanderRichert-NOAA commented Jul 6, 2023

I'm going to create a spack-stack test branch for this before merging...

Description

This PR updates ip recipe.

Issue(s) addressed

Addresses JCSDA/spack-stack#661

Dependencies

none

Impact

none

Checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have run the unit tests before creating the PR

@AlexanderRichert-NOAA AlexanderRichert-NOAA marked this pull request as draft July 6, 2023 18:09
@AlexanderRichert-NOAA AlexanderRichert-NOAA marked this pull request as ready for review July 10, 2023 23:36
Copy link
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you make any of these changes in spack authoritative already?

@AlexanderRichert-NOAA
Copy link
Collaborator Author

Yes-- note commit 58357cc is based on main spack (spack#38526).

@climbfuji
Copy link
Collaborator

Yes-- note commit 58357cc is based on main spack (spack#38526).

I think that update will come in via #295, or at least that PR should come first?

@AlexanderRichert-NOAA
Copy link
Collaborator Author

Yes it will, and the order doesn't matter (I don't mind waiting for #295).

@AlexanderRichert-NOAA
Copy link
Collaborator Author

Mooted by latest main spack merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants