release/1.60: bug fix for mapl with mvapich2 #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
ulmononian
approved these changes
Jul 10, 2024
14 tasks
|
@climbfuji Ah. Apologies. I guess I haven't used mvapich2 in a while and didn't realize there was an One suggestion would be: elif self.spec.satisfies("^mvapich2"):
args.append(self.define("MPI_STACK", "mvapich"))to match the Footnotes
|
mathomp4
reviewed
Jul 10, 2024
Co-authored-by: Matt Thompson <[email protected]>
|
Thanks @mathomp4 also pushed your bug fix to the spack develop PR |
mathomp4
approved these changes
Jul 10, 2024
|
Huh. I'll have to look at that license style issue. I mean, I think it's right... |
That's only because it's an old release of spack-stack. As long as it works for spack develop and our spack-stack-dev fork, all good. |
climbfuji
added a commit
to JCSDA/spack-stack
that referenced
this pull request
Jul 10, 2024
…ils modulefile (wgrib env var) (#1190) 1. Bug fix for mapl with mvapich2 (see JCSDA/spack#449) 2. Bugf ix for grib-utils module file (wgrib env var)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Yet another bug fix for
maplforrelease/1.6.0because it wants to configure MPI providers itself. Need to addmvapich2, because Hercules usesmvapich2for spack-stack-1.6.0 withgcc. I will also cherry-pick this and send it to spack develop.Ignore the failing style tests!
Testing
Corresponding spack-stack PR: JCSDA/spack-stack#1190