Updates towards compiling full unified environment with Intel oneAPI compilers (icx, icpx, ifort) #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
climbfuji
force-pushed
the
feature/steps_towards_unified_env_with_oneapi
branch
from
9f2e48e
to
8921f12
Compare
…/Fortran blocks by mistake with correct logic
climbfuji
force-pushed
the
feature/steps_towards_unified_env_with_oneapi
branch
from
8921f12
to
3e55f09
Compare
… feature/steps_towards_unified_env_with_oneapi
4 tasks
|
Upstream spack PRs are all approved and in the auto-merge queue - will merge this, because also the parent spack-stack PR of this PR has been approved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Several unrelated updates and a rather important bug fix that bring us one step closer to compiling the entire unified environment with the mixed Intel oneAPI compilers (icx, icpx, ifort):
fckit: Straightforward, Upstream PR for spack develop: Update fckit to build with Intel oneAPI compilers (icx, icpx) and nvhpc compilers spack/spack#45196 (includes an earlier update we made in spack-stack-dev for compiling withnvhpc).qt: First, pulled in updates (two mostrecent commits) for the package from spack develop, then added the workaround for oneAPI. Tested successfully on Blackpearl (compiledqtandecflowwith oneAPI, then start ecflow server and ecflow GUI). Upstream PR for spack develop: Add support for compiling [email protected] with Intel oneAPI compilers (icx, icpx) spack/spack#45195lib/spack/env/cc: I mistakenly copied the C++logic into the Fortran block and nobody noticed it. This fixes it. Note that the entirevcheck_flagslogic inlib/spack/env/ccwill eventually be replaced by a better solution. But since I am currently iterating with the spack developers on how that solution should look like (see Fix lib/spack/env/cc: pass Intel oneAPI flags to suppress deprecation… spack/spack#44588), let's merge this important bug fix now.Corresponding spack-stack PR: JCSDA/spack-stack#1195