Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Store Channels to FinderUtil #90

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add Store Channels to FinderUtil #90

wants to merge 3 commits into from

Conversation

Mikusch
Copy link

@Mikusch Mikusch commented Jul 22, 2019

Pull Request

Pull Request Checklist

Please follow the following steps before opening this PR.

PRs that do not complete the checklist will be subject to denial for
missing information.

Pull Request Information

Check and fill in the blanks for all that apply:

  • My PR fixes a bug, error, or other issue with the library's codebase.
  • My PR is for the commons module of the JDA-Utilities library.
  • My PR creates a new module for the JDA-Utilities library: ______.

Description

This PR adds JDA 4's Store Channels to the FinderUtil class and removes the genericTextChannelSearch, genericVoiceChannelSearch, and genericCategorySearch methods in favor of one generic channel search method.

@Mikusch Mikusch changed the title Enhancement/storechannel finder Add Store Channels to FinderUtil Jul 22, 2019
@Mikusch
Copy link
Author

Mikusch commented Jul 22, 2019

findStoreChannels(String, JDA) does not query a ShardManager if it is present at the moment. This is due to ShardManager missing the related cache access methods as of version 4.BETA.0_25.

I only realized that after creating this PR (I simply thought store channels weren't cached in the ShardManager for some odd reason).

I've opened another PR over at discord-jda/JDA#1060 to add those methods in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant