Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved mobile interface with simple css changes #15

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Noahkoole
Copy link

Have improved the interface for mobile by changing the layout of the buttons on smaller screen sizes

@JJCUBER
Copy link
Owner

JJCUBER commented May 4, 2024

A lot seems to get changed, so I will take a closer look tomorrow. Thank you for your contribution!

At first glance, I notice a removal of some portions of the css which were required to make html-to-image properly generate the image without incorrect colors/issues on specific devices. Unfortunately, I do not recall which devices are impacted by this, so I will look back through some of my past private commits to hopefully find this out (and test the respective devices).

(Also note that certain things were only issues [such as CORS issues] when hosting through github pages, as opposed to locally.)

One other thing to note is that I found this odd quirk for certain iOS devices where there is an extreme input delay if the font size/scale of things isn't large enough (along with issues with scrolling and zooming in if the font size of input fields aren't large enough).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants