Fix showInView method #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
August 10, 2013 22:33
Before it only looked at the KeyWindow of the Application, which will cause the action sheet to be presented underneath any custom modally-presented view. Before this method didn't utilize the parentView at all.
Makes sense...the modal ActionSheet should be above all root views in the Window.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before it didn't even use the parentView parameter. Now it utilizes it if not nil, or defaults to the keyWindows highest level subview, instead of it's lowest (keyWindow.subviews.lastObject vs keyWindow.subviews[0]) which makes more sense being a modal view.