feat: improve Visitors

Signed-off-by: Andreas Reichel <[email protected]>
JSQLParser · Jul 7, 2024 · 8a662af · 8a662af
1 parent 13572a8
commit 8a662af
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 10 deletions.
diff --git a/src/main/java/net/sf/jsqlparser/expression/ExpressionVisitor.java b/src/main/java/net/sf/jsqlparser/expression/ExpressionVisitor.java
@@ -302,10 +302,6 @@ default void visit(ContainedBy containedBy) {
 
     <S> T visit(ParenthesedSelect select, S context);
 
-    default void visit(ParenthesedSelect select) {
-        this.visit(select, null);
-    }
-
     <S> T visit(Column column, S context);
 
     default void visit(Column column) {
@@ -596,10 +592,6 @@ default void visit(GeometryDistance geometryDistance) {
 
     <S> T visit(Select select, S context);
 
-    default void visit(Select select) {
-        this.visit(select, null);
-    }
-
     <S> T visit(TranscodingFunction transcodingFunction, S context);
 
     default void visit(TranscodingFunction transcodingFunction) {

diff --git a/src/main/java/net/sf/jsqlparser/statement/select/SelectVisitorAdapter.java b/src/main/java/net/sf/jsqlparser/statement/select/SelectVisitorAdapter.java
@@ -24,12 +24,15 @@ public <S> T visit(PlainSelect plainSelect, S context) {
 
     @Override
     public <S> T visit(SetOperationList setOpList, S context) {
+        for (Select select : setOpList.getSelects()) {
+            select.accept(this, context);
+        }
         return null;
     }
 
     @Override
     public <S> T visit(WithItem withItem, S context) {
-        return null;
+        return withItem.getSelect().accept(this, context);
     }
 
     @Override
@@ -39,7 +42,7 @@ public <S> T visit(Values aThis, S context) {
 
     @Override
     public <S> T visit(LateralSubSelect lateralSubSelect, S context) {
-        return null;
+        return lateralSubSelect.getSelect().accept(this, context);
     }
 
     @Override