fix: [FEATURE] TablesNamesFinder does not support CREATE VIEW #2123 (#…

…2124)
JSQLParser · Dec 15, 2024 · 8f8439e · 8f8439e
1 parent 18c1a2c
commit 8f8439e
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/src/main/java/net/sf/jsqlparser/util/TablesNamesFinder.java b/src/main/java/net/sf/jsqlparser/util/TablesNamesFinder.java
@@ -1151,8 +1151,11 @@ public void visit(CreateTable createTable) {
     }
 
     @Override
-    public <S> Void visit(CreateView createView, S context) {
-        throwUnsupported(createView);
+    public <S> Void visit(CreateView create, S context) {
+        visit(create.getView(), null);
+        if (create.getSelect() != null) {
+            create.getSelect().accept((SelectVisitor<?>) this, context);
+        }
         return null;
     }
 

diff --git a/src/test/java/net/sf/jsqlparser/util/TablesNamesFinderTest.java b/src/test/java/net/sf/jsqlparser/util/TablesNamesFinderTest.java
@@ -152,12 +152,19 @@ public void testInsertSelect() throws Exception {
     }
 
     @Test
-    public void testCreateSelect() throws Exception {
+    public void testCreateTableSelect() throws Exception {
         String sqlStr = "CREATE TABLE mytable AS SELECT mycolumn FROM mytable2";
         assertThat(TablesNamesFinder.findTables(sqlStr)).containsExactlyInAnyOrder("mytable",
                 "mytable2");
     }
 
+    @Test
+    public void testCreateViewSelect() throws Exception {
+        String sqlStr = "CREATE VIEW mytable AS SELECT mycolumn FROM mytable2";
+        assertThat(TablesNamesFinder.findTables(sqlStr)).containsExactlyInAnyOrder("mytable",
+                "mytable2");
+    }
+
     @Test
     public void testInsertSubSelect() throws JSQLParserException {
         String sqlStr =