Protobuf support

[pantonis]

Is this library compatible with protobuf?

Thanks.

[JSteunou]

It does not use protobuf, but you can use protobuf above it. This client is quite low-level, so I do support only what the STOMP spec support.

[pantonis]

I can see from the source that everything is converted into string.

this.ws.onmessage = (evt) => {
            let data = evt.data;
            if (evt.data instanceof ArrayBuffer) {
                data = typedArrayToUnicodeString(new Uint8Array(evt.data));
            }

If the data is converted into string I cannot deserialize it then using protobuf js.

[JSteunou]

Going through String is mandatory in order to decode the STOMP frame.

[pantonis]

what about going through string for headers and leave the body intact for further processing by the protobuf library?

[JSteunou]

Could you show me how you would do that? A clean PR (pull request) could help.

[pantonis]

Have a look at the following:

How-to-read-binary-data-in-the-browser-or-under-node.js

[JSteunou]

This is not XHR protocol with HTTP, it's websocket with STOMP frames.

[pantonis]

When reading/writing binary data in the browser or under node.js, it is mandatory to understand that just reading it (as a string) is not enough. When doing this, the data will probably become corrupted when it is converted between character sets and ProtoBuf.js will not be able to decode it or will return random stuff. What's actually required here is to properly handle the data as binary.

It is still read as string. So corruption happens when original body contect is read as string.

[pantonis]

I have seen the same problem and suggestion I wrote here in this thread but it seems that it is not maintained anymore

stomp-websocket

[JSteunou]

This is fixed in this fork

[pantonis]

adamish commented on Dec 10, 2014 comment is fixed here?

[pantonis]

Hi,

I get the following error when using protobuf

[pantonis]

??

[pantonis]

I can confirm that this was not fixed as you stated.

[idcmp]

Spring 5.0.7+ recommends this variant of the STOMP library for browser clients, and while it's possible to send binary via this library (and the Spring implementation of STOMP is binary safe), this issue prevents developers from sending binary replies.

So without some massaging on the server, protobuf is not supported.

That said, I'm not sure if this library is still the best fork for developers to use.

[JSteunou]

This fork matches my need, but you are welcome to contribute via PR ;)