This repository has been archived by the owner on May 5, 2021. It is now read-only.
Support binary data in "body" #68
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 52fe113.
# Conflicts: # dist/webstomp.js # src/frame.js
|
Could you make this PR cleaner / clearer without pushing the dist files? |
|
Since you have dist files in the repo, I can't just remove them from tree source, so I don't know how to do it. |
|
Sure this repo have dist files, but in any project, when making a PR, you must only push changed in source files so they can be picked and merged. Only the maintainer will build tag release publish etc. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is raw implementation for working with binary data in "body" block.
If client and server work in binary mode, command and headers splits and converted in strings and and leave the body intact.
PR addresses problem described here #21
I think some review, testing and polish is needed, but it seems to work.