QA-15380: Issue with customized preview and aliased user #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
baptistegrimaud
force-pushed
the
QA-15380-issue-with-customized-preview-and-aliased-user
branch
2 times, most recently
from
89a791d to
90d480f
Compare
jkevan
approved these changes
Dec 13, 2024
baptistegrimaud
force-pushed
the
QA-15380-issue-with-customized-preview-and-aliased-user
branch
from
90d480f to
155d17d
Compare
baptistegrimaud
deleted the
QA-15380-issue-with-customized-preview-and-aliased-user
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.jahia.org/browse/QA-15380
Description
Fix an issue with customized preview for Javascript modules for content with virtual nodes.
The virtual nodes are correctly created (temporarily) in the session of the aliased user, however the rendering was performed with the current user, causing a
ItemNotFoundException. The rendering now uses the aliased user if any, and fallback to the current user otherwise.Tests
The following are included in this PR