Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BACKLOG-23347: Show SEO section only for certain nodetypes #256

Merged
merged 3 commits into from
Jan 9, 2025
Merged

BACKLOG-23347: Show SEO section only for certain nodetypes #256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
15f51f1
BACKLOG-23347: Show SEO section only for certain nodetypes
gflores-jahia Jan 8, 2025
0b8e19a
BACKLOG-23500: Add ordering
gflores-jahia Jan 8, 2025
48258f3
Use default lts node version for static-analysis workflow
gflores-jahia Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/on-code-change.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ jobs:
- uses: Jahia/jahia-modules-action/static-analysis@v2
with:
skip_lint_modules: true
node_version: 14
auditci_level: critical

build:
Expand Down
3 changes: 3 additions & 0 deletions ...urces/META-INF/jahia-content-editor-forms/forms/jmix_mainResource_rename_description.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,12 @@
"sections": [
{
"name": "seo",
"hide": false,
"fieldSets": [
{
"name": "htmlHead",
"labelKey": "site-settings-seo:seo.htmlHeadSection.label",
"rank": 0.1,
"fields": [
{
"name": "jcr:description",
Expand All @@ -30,6 +32,7 @@
},
{
"name": "jmix:seoHtmlHead",
"rank": 0.2,
"isAlwaysActivated": true,
"alwaysPresent": true,
"hide": true
Expand Down
3 changes: 3 additions & 0 deletions ...main/resources/META-INF/jahia-content-editor-forms/forms/jnt_page_rename_description.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,12 @@
"sections": [
{
"name": "seo",
"hide": false,
"fieldSets": [
{
"name": "htmlHead",
"labelKey": "site-settings-seo:seo.htmlHeadSection.label",
"rank": 0.1,
"fields": [
{
"name": "jcr:description",
Expand All @@ -30,6 +32,7 @@
},
{
"name": "jmix:seoHtmlHead",
"rank": 0.2,
"isAlwaysActivated": true,
"alwaysPresent": true,
"hide": true
Expand Down
6 changes: 4 additions & 2 deletions tests/cypress/e2e/seoOverrides/definitions.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,10 @@ describe('New SEO field definition tests', () => {
})
})

it('should not have new SEO fields for other types', function () {
JContent.visit(siteKey, 'en', 'content-folders/contents').createContent('Rich text').openSection('seo')
it('should not have SEO section and new SEO fields for other types', function () {
JContent.visit(siteKey, 'en', 'content-folders/contents').createContent('Rich text')
cy.get(`[data-sel-content-editor-fields-group="seo"]`).should('not.exist', { timeout: 10000 })

const assertFieldNotExist = (contentType) => {
cy.get(`[data-sel-content-editor-field="${contentType}"]`).should('not.exist', { timeout: 10000 })
}
Expand Down
Loading