Skip to content
This repository has been archived by the owner on Jul 1, 2023. It is now read-only.

PHP 7.4: fix deprecation notice #143

Closed

Conversation

jrfnl
Copy link

@jrfnl jrfnl commented Aug 18, 2019

PHP 7.4 deprecates the use of curly braces for array/string character access.

See: https://wiki.php.net/rfc/deprecate_curly_braces_array_access

PHP 7.4 deprecates the use of curly braces for array/string character access.

See: https://wiki.php.net/rfc/deprecate_curly_braces_array_access
@jrfnl
Copy link
Author

jrfnl commented Oct 5, 2019

@JakubOnderka Anything I can do to move this PR (and the others I opened) forward ?

@jrfnl
Copy link
Author

jrfnl commented Nov 6, 2019

@JakubOnderka Bumping again... I know the build on this PR doesn't pass, but in combination with my other PRs the build will start passing again.

Could this (and my other PRs) please get some attention ?

The tool not being compatible with PHP 7.4 is a blocker to start using it for a number of projects I'm involved with.

@nicwortel
Copy link

This will solve #154.

@JakubOnderka merging (and releasing) this PR would be greatly appreciated!

@szepeviktor
Copy link

@JakubOnderka Could you help this PR to be merged?

@szepeviktor
Copy link

@jrfnl What would you say if I fork this and merge all PR-s, resolve all issues there?

@jrfnl
Copy link
Author

jrfnl commented Dec 17, 2019

@szepeviktor I already have (to confirm that the combined PRs fix all build issues) : https://github.com/jrfnl/PHP-Parallel-Lint/tree/test/all-together-now

@szepeviktor
Copy link

I see https://github.com/jrfnl/PHP-Parallel-Lint/commits/test/all-together-now

How about publishing and maintaining it?

@jrfnl
Copy link
Author

jrfnl commented Dec 17, 2019

@szepeviktor If @JakubOnderka is abandoning this project and would confirm this, I'd definitely consider it. Otherwise, I think it be better for this canonical to be updated instead.

@szepeviktor
Copy link

Ci fixed in #155

@ramondelafuente
Copy link

I've switched to @jrfnl's branch for now, but I agree that maintenance should not move implicitly.

@JakubOnderka You've done great work with this, and it's perfectly fine not to jump at every ticket. But it looks like the PR's that have been opened are valid. Do you intend to merge and keep maintaining this package?

@grogy
Copy link
Contributor

grogy commented Jan 27, 2020

Hi,

I am using your PR for solve problems. Because author of this great tool does not communicate so I created fork. You can use it from packagist. Now is out new release with PHP 7.4 support.

@Krinkle
Copy link
Contributor

Krinkle commented Mar 15, 2020

The fork from @grogy has been officially recognised and continues under a new GitHub organisation at https://github.com/php-parallel-lint/PHP-Parallel-Lint.

This move is recognised in the project's readme (commit).

Thank you @JakubOnderka! 🎉

@jrfnl
Copy link
Author

jrfnl commented Mar 15, 2020

@Krinkle Great news, though it would be even nicer if PRs opened there would start getting merged... 10 open PRs and counting. 8 which are over 3 weeks old by now. 😍

/cc @grogy

@jrfnl
Copy link
Author

jrfnl commented Mar 15, 2020

Closing as this has been merged in the new repo: https://github.com/php-parallel-lint/PHP-Parallel-Lint

@jrfnl jrfnl closed this Mar 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants