-
Notifications
You must be signed in to change notification settings - Fork 62
PHP 7.4: fix deprecation notice #143
PHP 7.4: fix deprecation notice #143
Conversation
PHP 7.4 deprecates the use of curly braces for array/string character access. See: https://wiki.php.net/rfc/deprecate_curly_braces_array_access
@JakubOnderka Anything I can do to move this PR (and the others I opened) forward ? |
@JakubOnderka Bumping again... I know the build on this PR doesn't pass, but in combination with my other PRs the build will start passing again. Could this (and my other PRs) please get some attention ? The tool not being compatible with PHP 7.4 is a blocker to start using it for a number of projects I'm involved with. |
This will solve #154. @JakubOnderka merging (and releasing) this PR would be greatly appreciated! |
@JakubOnderka Could you help this PR to be merged? |
@jrfnl What would you say if I fork this and merge all PR-s, resolve all issues there? |
@szepeviktor I already have (to confirm that the combined PRs fix all build issues) : https://github.com/jrfnl/PHP-Parallel-Lint/tree/test/all-together-now |
I see https://github.com/jrfnl/PHP-Parallel-Lint/commits/test/all-together-now How about publishing and maintaining it? |
@szepeviktor If @JakubOnderka is abandoning this project and would confirm this, I'd definitely consider it. Otherwise, I think it be better for this canonical to be updated instead. |
Ci fixed in #155 |
I've switched to @jrfnl's branch for now, but I agree that maintenance should not move implicitly. @JakubOnderka You've done great work with this, and it's perfectly fine not to jump at every ticket. But it looks like the PR's that have been opened are valid. Do you intend to merge and keep maintaining this package? |
Hi, I am using your PR for solve problems. Because author of this great tool does not communicate so I created fork. You can use it from packagist. Now is out new release with PHP 7.4 support. |
The fork from @grogy has been officially recognised and continues under a new GitHub organisation at https://github.com/php-parallel-lint/PHP-Parallel-Lint. This move is recognised in the project's readme (commit). Thank you @JakubOnderka! 🎉 |
Closing as this has been merged in the new repo: https://github.com/php-parallel-lint/PHP-Parallel-Lint |
PHP 7.4 deprecates the use of curly braces for array/string character access.
See: https://wiki.php.net/rfc/deprecate_curly_braces_array_access