Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak suggestion order #4401

Merged
merged 3 commits into from
Sep 20, 2024
Merged

Tweak suggestion order #4401

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
248c52d
Prioritize lower case over upper
James-Yu Sep 20, 2024
097d381
Starred macros come after normal ones
James-Yu Sep 20, 2024
cd76bf9
Fix #4400 Prioritize `\(`, give `|` an order
James-Yu Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/completion/completer/environment.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,7 @@ function entryEnvToCompletion(item: EnvironmentInfo, type: EnvSnippetType): CmdE
if (item.package) {
suggestion.documentation += ` From package: ${item.package}.`
}
suggestion.sortText = label.replace(/([A-Z])/g, '$10').toLowerCase()
suggestion.sortText = label.replace(/([a-z])/g, '$10').toLowerCase()

if (type === EnvSnippetType.AsName) {
return suggestion
Expand Down
6 changes: 4 additions & 2 deletions src/completion/completer/macro.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,10 +421,12 @@ function entryCmdToCompletion(item: MacroRaw, packageName?: string, postAction?:
suggestion.documentation += ` From package: ${packageName}.`
}
suggestion.sortText = (item.name + (item.arg?.format ?? ''))
.replace(/([A-Z])/g, '$10').toLowerCase()
.replace(/([a-z])/g, '$10').toLowerCase()
.replaceAll('{', '0')
.replaceAll('[', '1')
.replaceAll('(', '2')
.replace(/^(.+?)\(/g, '$12') // Skip \(
.replaceAll('|', '3')
.replaceAll('*', '9')
if (postAction) {
suggestion.command = { title: 'Post-Action', command: postAction }
} else if (isTriggerSuggestNeeded(item.name)) {
Expand Down
Loading