fix link highlighting in \ref and \input for non-word characters #4448
Conversation
|
Thanks for your contribution! @jlelong I really cannot recall the implementations on symbol definitions. The modifications look good to me at first sight. May you take a look on them? Many thanks! |
|
@v4hn Thank you for your contribution. May I ask you to add comments to explain the meaning/content of variables and describe the logic for future maintenance? |
For sure. I will on Tuesday. I am away from my computer for two days. |
v4hn
force-pushed
the
pr-fix-broken-symbol-decoration
branch
from
a01e6ac to
344a373
Compare
Done |
code version 1.26 (2018) added support for custom symbol selection range through DefinitionLink when providing definitions: https://code.visualstudio.com/updates/v1_26#_definitionlink Making use of the interface we don't get unexpected splits of symbols in words anymore. E.g., before `\ref{fig:abc}` would turn only "fig" or "abc" into a link when hovering over it with `<Ctrl>` held. Also addresses the same problem with file names in `\input{abc_def}`.
v4hn
force-pushed
the
pr-fix-broken-symbol-decoration
branch
from
344a373 to
a177a16
Compare
|
Gentle ping? |
code version 1.26 (2018) added support for custom symbol selection range through DefinitionLink when providing definitions. The feature was missed in the previous discussion.
Making use of the interface we don't get unexpected splits of symbols in words anymore.
Fixes #4446 and #3312 .
Before
After