fix #4474 #4475
Merged
fix #4474 #4475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
James-Yu
requested changes
Dec 2, 2024
src/lint/latex-formatter/tex-fmt.ts
Outdated
|
|
||
| // remove extra newline at the end | ||
| if (edits) { | ||
| edits.newText = edits.newText.replace(/\n$/, '') |
There was a problem hiding this comment.
... and remove the new line char accordingly.
src/lint/latex-formatter/tex-fmt.ts
Outdated
| @@ -43,9 +43,13 @@ async function formatDocument(document: vscode.TextDocument, range?: vscode.Rang | |||
| }) | |||
| }) | |||
|
|
|||
| process.stdin?.write(document.getText(range)) | |||
| // write the document to the process, and add a newline at the end | |||
There was a problem hiding this comment.
As this is a workaround of an external piece of software, please add corresponding documents describing the date, version of tex-fmt, and the context of the workaround.
|
I have corrected the code, but I am unsure whether it is appropriate to write the documentation directly as comments within the code. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By adding an extra "\n" at the end of the input text and remove it after using
tex-fmt, the problem is solved.