Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve json-schema file #200

Closed
wants to merge 3 commits into from
Closed

Conversation

chaseholdren
Copy link

@chaseholdren chaseholdren commented Feb 20, 2024

This PR changes some types so the generated schema.json file is more accurate. Before this change, schema.json had DependencyType could be an object. I tested this by running pnpm run build:json-schema and then uploaded the result as a gist, which I could reference from another project.

@JamieMason
Copy link
Owner

very nice @chaseholdren, thanks a lot!

@evaliyev
Copy link
Contributor

Is this PR related to #207?

@JamieMason
Copy link
Owner

This line should address that @evaliyev, I've not had chance to look deeper into what the other changes are yet but @chaseholdren may comment on those in the meantime to give us some more context.

export interface JsonSchema extends RcConfig {
$schema?: string;
}

@KubaJastrz
Copy link

Hello, can we push this forward somehow?

@JamieMason
Copy link
Owner

Released in 12.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants