fix: blanks in dav Content-Disposition header

Fixes the encoding of blanks in the dav `Content-Disposition` header. This is a regression caused by cs3org#4748.
JammingBen · Jul 12, 2024 · b6e7cc5 · b6e7cc5
1 parent 633973b
commit b6e7cc5
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/changelog/unreleased/fix-blanks-in-content-disposition-headers.md b/changelog/unreleased/fix-blanks-in-content-disposition-headers.md
@@ -0,0 +1,6 @@
+Bugfix: Blanks in dav Content-Disposition header
+
+We've fixed the encoding of blanks in the dav `Content-Disposition` header.
+
+https://github.com/cs3org/reva/pull/4762
+https://github.com/owncloud/web/issues/11169
diff --git a/internal/http/services/owncloud/ocdav/net/builders.go b/internal/http/services/owncloud/ocdav/net/builders.go
@@ -28,7 +28,7 @@ import (
 
 // ContentDispositionAttachment builds a ContentDisposition Attachment header with various filename encodings
 func ContentDispositionAttachment(filename string) string {
-	return "attachment; filename*=UTF-8''" + url.QueryEscape(filename) + "; filename=\"" + filename + "\""
+	return "attachment; filename*=UTF-8''" + url.PathEscape(filename) + "; filename=\"" + filename + "\""
 }
 
 // RFC1123Z formats a CS3 Timestamp to be used in HTTP headers like Last-Modified