-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add written documentation for errors and metrics #116
Conversation
@cmalinmayor I took a stab at the division errors page. I just used super simple text based diagrams like we use in the docstrings for tests. We may want to upgrade to something fancier in the future, but I don't want the plotting to become a blocker to writing. https://traccuracy--116.org.readthedocs.build/en/116/track_errors/divisions.html |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #116 +/- ##
==========================================
+ Coverage 83.01% 83.64% +0.62%
==========================================
Files 18 19 +1
Lines 848 899 +51
==========================================
+ Hits 704 752 +48
- Misses 144 147 +3 ☔ View full report in Codecov by Sentry. |
True Positive | ||
------------- | ||
|
||
A true positive division is a division event in which the parent and both daughters match between the ground truth and predicted graphs. True positive divisions are annotated on both the ground truth and predicted graphs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you say that they are annotated on the parent node specifically? That's what we do, right?
Ooh I like it a lot!! I think if we should implement this for all metrics and then we can make it fancier later if we have time and inclination, but this is so much better than nothing. |
@DragaDoncila Caroline and I started this branch to work towards closing #77 by adding pages in the sidebar for each error annotation type and downstream metrics. Can you take a stab at the ctc related pages which I think would be |
@msschwartz21 would you like me to PR into this branch for these docs, or review this PR independently and make another for the CTC docs |
I'd prefer to get all of the docs changes in place before we merge into main so let's do a PR or direct push to this branch. |
* Add some docs * Hopefully get rid of warning * Split different error weights into list * Add TRA def * Fix space * Add a bit about AOGM --------- Co-authored-by: Draga Doncila <[email protected]>
@msschwartz21 I merged some additions to the CTC docs! |
Since we are starting to get a few more eyes on traccuracy, I'm leaning towards a mindset of some incomplete documentation is better than no documentation at all. To that end, I added a note block to the pages we haven't written yet saying "Coming soon!" @DragaDoncila @cmalinmayor Does this sound ok to you? I'll open up an issue to keep track of the remaining pages that we need to write. |
I very much agree. Some docs better than no docs! |
I'm opening this as a draft so that we can take a look at the RTD preview while we are working on it.
Pages to write: