Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iou matcher option to use linear assignment to get one-to-one matching #150

Merged
merged 8 commits into from
Aug 2, 2024

Conversation

msschwartz21
Copy link
Collaborator

@msschwartz21 msschwartz21 commented Aug 2, 2024

Proposed Change

This PR adds an option to the IOUMatcher to force the mapping to be one-to-one using linear sum assignment. Enabling this option makes the IOUMatcher compatible with division metrics.

Types of Changes

What types of changes does your code introduce? Put an x in the boxes that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature or enhancement
  • Documentation update
  • Tests and benchmarks
  • Maintenance (e.g. dependencies, CI, releases, etc.)

Which topics does your change affect? Put an x in the boxes that apply.

  • Loaders
  • Matchers
  • Track Errors
  • Metrics
  • Core functionality (e.g. TrackingGraph, run_metrics, cli, etc.)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the developer/contributing docs.
  • I have added tests that prove that my feature works in various situations or tests the bugfix (if appropriate).
  • I have checked that I maintained or improved code coverage.
  • I have checked the benchmarking action to verify that my changes did not adversely affect performance.
  • I have written docstrings and checked that they render correctly in the Read The Docs build (created after the PR is opened).
  • I have updated the general documentation including Metric descriptions and example notebooks if necessary.

@msschwartz21 msschwartz21 added enhancement New feature or request topic: matcher labels Aug 2, 2024
@msschwartz21 msschwartz21 merged commit ffe7cb1 into main Aug 2, 2024
13 checks passed
@msschwartz21 msschwartz21 deleted the iou-1-to-1 branch August 2, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request topic: matcher
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants