Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[blog]Added blog for Option And Composition API #117

Merged
merged 5 commits into from
Mar 12, 2024
Merged

[blog]Added blog for Option And Composition API #117

merged 5 commits into from
Mar 12, 2024

Conversation

SagarGi
Copy link
Contributor

@SagarGi SagarGi commented Nov 26, 2023 •
edited
Loading

Description

Added Blog about Option API and Composition API on how we can convert a component defined on Option API to Composition API

@SagarGi SagarGi self-assigned this Dec 11, 2023
@SagarGi SagarGi added the blog New blog label Dec 11, 2023
@SagarGi SagarGi marked this pull request as ready for review December 11, 2023 06:33
@SagarGi SagarGi requested a review from a team December 11, 2023 06:33
SwikritiT
SwikritiT reviewed Dec 12, 2023
View reviewed changes
Copy link
Contributor

@SwikritiT SwikritiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

koebel
koebel reviewed Dec 12, 2023
View reviewed changes
Copy link
Contributor

@koebel koebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I did correct some minor spelling mistakes. Phil can maybe have a look at this too, as a native English speaker he is certainly better than me in this :)
Make sure that you are consistent in how you write some of the key terms throughout the article. I've also added two or three notes where as I user I would love to learn a little bit more about the difference of the two APIs :)

src/assets/VueOptionVsCompositionAPI/option-vs-composition-api.md Outdated Show resolved Hide resolved
src/assets/VueOptionVsCompositionAPI/option-vs-composition-api.md Outdated Show resolved Hide resolved
src/assets/VueOptionVsCompositionAPI/option-vs-composition-api.md Outdated Show resolved Hide resolved
src/assets/VueOptionVsCompositionAPI/option-vs-composition-api.md Outdated Show resolved Hide resolved
src/assets/VueOptionVsCompositionAPI/option-vs-composition-api.md Outdated Show resolved Hide resolved
src/assets/VueOptionVsCompositionAPI/option-vs-composition-api.md Outdated Show resolved Hide resolved
src/assets/VueOptionVsCompositionAPI/option-vs-composition-api.md Outdated Show resolved Hide resolved
src/assets/VueOptionVsCompositionAPI/option-vs-composition-api.md Outdated Show resolved Hide resolved
src/assets/VueOptionVsCompositionAPI/option-vs-composition-api.md Outdated Show resolved Hide resolved
src/assets/VueOptionVsCompositionAPI/option-vs-composition-api.md Outdated Show resolved Hide resolved
@koebel koebel self-requested a review December 18, 2023 04:52
@SagarGi SagarGi removed the request for review from SwikritiT February 1, 2024 05:39
koebel
koebel reviewed Feb 1, 2024
View reviewed changes
Copy link
Contributor

@koebel koebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few more minor comments and suggestions about English spelling :)

I also suggest to rename the .md file to options-vs-... to be consistent with using the correct name of the Options API

src/assets/VueOptionVsCompositionAPI/option-vs-composition-api.md Outdated Show resolved Hide resolved
src/assets/VueOptionVsCompositionAPI/option-vs-composition-api.md Outdated Show resolved Hide resolved
src/assets/VueOptionVsCompositionAPI/option-vs-composition-api.md Outdated Show resolved Hide resolved
src/assets/VueOptionVsCompositionAPI/option-vs-composition-api.md Outdated Show resolved Hide resolved
src/assets/VueOptionVsCompositionAPI/option-vs-composition-api.md Outdated Show resolved Hide resolved
src/assets/VueOptionVsCompositionAPI/option-vs-composition-api.md Outdated Show resolved Hide resolved
src/assets/VueOptionVsCompositionAPI/option-vs-composition-api.md Outdated Show resolved Hide resolved
src/assets/VueOptionVsCompositionAPI/option-vs-composition-api.md Outdated Show resolved Hide resolved
src/assets/VueOptionVsCompositionAPI/option-vs-composition-api.md Outdated Show resolved Hide resolved
src/assets/VueOptionVsCompositionAPI/option-vs-composition-api.md Outdated Show resolved Hide resolved
@SagarGi SagarGi force-pushed the compositionVsOptionAPIVue branch 2 times, most recently from 6997f6d to 43feedb Compare March 11, 2024 10:34
@SagarGi SagarGi requested a review from koebel March 11, 2024 10:35
grgprarup
grgprarup approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@grgprarup grgprarup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@SagarGi SagarGi merged commit 5ff4e8d into master Mar 12, 2024
1 check passed
@SagarGi SagarGi deleted the compositionVsOptionAPIVue branch March 12, 2024 09:06
SagarGi added a commit that referenced this pull request Mar 12, 2024
@SagarGi
[blog]Added blog for Option And Composition API (#117)
e4c65b3 
* Added blog for Option And Composition API

* Fix grammers

* final read and fix typos

* Review address

* Review address kathren
nabim777 pushed a commit that referenced this pull request Mar 12, 2024
@SagarGi @nabim777
[blog]Added blog for Option And Composition API (#117)
4b0243c 
* Added blog for Option And Composition API

* Fix grammers

* final read and fix typos

* Review address

* Review address kathren
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SwikritiT SwikritiT SwikritiT left review comments

@grgprarup grgprarup grgprarup approved these changes

@koebel koebel koebel approved these changes

@phil-davis phil-davis Awaiting requested review from phil-davis

@individual-it individual-it Awaiting requested review from individual-it

@Salipa-Gurung Salipa-Gurung Awaiting requested review from Salipa-Gurung

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@nabim777 nabim777 Awaiting requested review from nabim777

@S-Panta S-Panta Awaiting requested review from S-Panta

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

@nirajacharya2 nirajacharya2 Awaiting requested review from nirajacharya2

@saw-jan saw-jan Awaiting requested review from saw-jan

Assignees

@SagarGi SagarGi

Labels
blog New blog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SagarGi @koebel @grgprarup @SwikritiT @saw-jan