Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

table fix on dark mode #119

Merged
merged 1 commit into from
Mar 19, 2024
Merged

table fix on dark mode #119

merged 1 commit into from
Mar 19, 2024

Conversation

nabim777
Copy link
Member

@nabim777 nabim777 commented Mar 5, 2024

Issue Related to

After fixing the table color

Dark mode

image

light mode

image

@nabim777 nabim777 self-assigned this Mar 5, 2024
@nabim777 nabim777 marked this pull request as ready for review March 7, 2024 14:40
@nabim777 nabim777 force-pushed the fix-table-on-dark-mode branch 3 times, most recently from 81a2dc7 to c64fc58 Compare March 12, 2024 16:21
@koebel
Copy link
Contributor

koebel commented Mar 13, 2024

@nabim777 do the screenshots above reflect how the table looks like after the last changes?

@koebel
Copy link
Contributor

koebel commented Mar 13, 2024

by the way, I'm not sure if this is related to the current issue, but can you briefly have a look at line 135
background-color: #e2e0e0b4;
this doesn't seem to be a valid hex colour...

@nabim777
Copy link
Member Author

@nabim777 do the screenshots above reflect how the table looks like after the last changes?

Yes @koebel

Copy link
Contributor

@koebel koebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grgprarup grgprarup merged commit 84ab355 into master Mar 19, 2024
1 check passed
@grgprarup grgprarup deleted the fix-table-on-dark-mode branch March 19, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

font color adjustment for dark mode
4 participants