Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance search for sorting and filters #134

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Enhance search for sorting and filters #134

merged 1 commit into from
Jun 4, 2024

Conversation

SagarGi
Copy link
Contributor

@SagarGi SagarGi commented Jun 1, 2024

Fixes: #127

saw-jan
saw-jan previously approved these changes Jun 3, 2024
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

phil-davis
phil-davis previously approved these changes Jun 3, 2024
Copy link
Contributor

@koebel koebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor comments

src/views/HomeView.vue Outdated Show resolved Hide resolved
src/views/HomeView.vue Show resolved Hide resolved
src/views/HomeView.vue Show resolved Hide resolved
@SagarGi SagarGi dismissed stale reviews from phil-davis and saw-jan via a0cd9b3 June 4, 2024 02:54
@SagarGi SagarGi force-pushed the enhance/search branch 4 times, most recently from 1cb98ca to 38ab3e7 Compare June 4, 2024 03:46
Copy link
Contributor

@koebel koebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SagarGi SagarGi merged commit e05c5ce into master Jun 4, 2024
1 check passed
@SagarGi SagarGi deleted the enhance/search branch June 4, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UX/UI improvement: Enhance search by filter
6 participants