Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Added updatedAt attribute in blog meta #152

Merged
merged 6 commits into from
Jul 8, 2024

Conversation

grgprarup
Copy link
Contributor

@grgprarup grgprarup commented Jul 5, 2024

Description

The blog needs to be updated after some time because the blog will not be useful due to updates (like versions, and terminologies) in tools used while writing the blog.
In this PR, the attribute updatedAt is introduced in the blog metadata so the originally published date and updated date are shown in the blog post.

Feature

Result

  1. Blog Home View
    Before::
    Screenshot from 2024-07-05 16-29-23
    After::
    last_updated_blog
    No Updated At::
    Screenshot from 2024-07-08 09-34-27

  2. Blog Post View
    Before::
    Screenshot from 2024-07-05 16-29-42
    After::
    last_updated_post
    No Updated At::
    Screenshot from 2024-07-08 09-35-45

Issues

Fixes #148

@grgprarup grgprarup added the enhancement New feature or request label Jul 5, 2024
@grgprarup grgprarup mentioned this pull request Jul 5, 2024
@grgprarup grgprarup requested a review from a team July 5, 2024 11:08
@grgprarup grgprarup self-assigned this Jul 5, 2024
@koebel
Copy link
Contributor

koebel commented Jul 5, 2024

I like the suggestion. Maybe use the wording "last updated". And of course display it only if there has been an update. When updatedAt is empty, the suggested snipped shouldn't be displayed.

@grgprarup
Copy link
Contributor Author

I like the suggestion. Maybe use the wording "last updated". And of course display it only if there has been an update. When updatedAt is empty, the suggested snipped shouldn't be displayed.

The wording is changed to Last Updated. The rest of the suggestion was already implemented. updatedAt is optional and Last Updated only shows when the updatedAt is provided.

README.md Outdated Show resolved Hide resolved
koebel
koebel previously approved these changes Jul 8, 2024
Copy link
Contributor

@koebel koebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

README.md Outdated Show resolved Hide resolved
phil-davis
phil-davis previously approved these changes Jul 8, 2024
@grgprarup grgprarup dismissed stale reviews from phil-davis and koebel via 302a1ba July 8, 2024 10:22
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🚀

Copy link
Contributor

@koebel koebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grgprarup grgprarup merged commit eb8c91d into master Jul 8, 2024
1 check passed
@grgprarup grgprarup deleted the add-updated-at-meta branch July 8, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

created at vs. updated at
4 participants