File storage experiment fix #102
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JarnoRFB
requested changes
Mar 5, 2024
| name = artifact_path.name | ||
| artifacts[name] = Artifact(name, artifact_file) | ||
| artifacts[name] = Artifact(name, artifact_path) |
There was a problem hiding this comment.
Actually surprised that this works. However, the Artifact type expects something file like to keep it compatible with the MongoDB variant. For a change like this we would have to define a general protocol to abstract over local and MongoDB files.
There was a problem hiding this comment.
That is a good point. The main reason for this change was that the previous version opened artifact files without closing them, which lead to errors when loading a large number of experiments at once.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
info.jsonis not always created byFileStorageObserver, so load it only if the file exists inrun_dir.Artifactconstructor instead of opening it.