Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transaction error #2594

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Transaction error #2594

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a80da04
npgsql transaction error without bulk insert in test
ttichy May 15, 2023
2562282
small test fixup. There should be only 2 Targets
ttichy May 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/CoreTests/ability_to_use_an_existing_connection_and_transaction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ public ability_to_use_an_existing_connection_and_transaction(DefaultStoreFixture

protected override Task fixtureSetup()
{
return Task.CompletedTask;
return theStore.BulkInsertDocumentsAsync(targets);
}

Expand Down Expand Up @@ -107,7 +108,7 @@ public void enlist_in_transaction_scope()
using (var session = theStore.QuerySession())
{
//See https://github.com/npgsql/npgsql/issues/1483 - Npgsql by default is enlisting
session.Query<Target>().Count().ShouldBe(102);
session.Query<Target>().Count().ShouldBe(2);
}

scope.Complete();
Expand Down Expand Up @@ -136,7 +137,7 @@ public void enlist_in_transaction_scope_by_transaction()
using (var session = theStore.QuerySession())
{
//See https://github.com/npgsql/npgsql/issues/1483 - Npgsql by default is enlisting
session.Query<Target>().Count().ShouldBe(102);
session.Query<Target>().Count().ShouldBe(2);
}

scope.Complete();
Expand All @@ -145,7 +146,7 @@ public void enlist_in_transaction_scope_by_transaction()
// should be 2 additional targets
using (var session = theStore.QuerySession())
{
session.Query<Target>().Count().ShouldBe(102);
session.Query<Target>().Count().ShouldBe(2);
}
}

Expand Down