21976 Added cont in legal types to misc logic (bcgov#578)

* - app version = 4.10.2 - imported latest corp type module - renamed isXXX -> isEntityXXX - added missing C/CBEN/CCC/CUL getters - added new legal types to misc logic - updated unit tests - WIP * - renamed computed/prop isBenefit -> isBenefitCompany for consistency - added new entity types to PeopleAndRoles.vue - added new entity types to ChangeBusinessType.vue - fixed some bugs in ChangeBusinessType.vue - improved an interface - added new entity types to filing-template-mixin.ts - added typing to misc resource files - renamed resource files from XXXResource -> ResourceXXX - added resource files for alterations, corrections and restorations (x2) - removed unneeded store getters - added new entity types to Alteration.vue - added new entity types to LimitedRestorationExtension.vue - added new entity types to LimitedRestorationToFull.vue - added new entity types to CorpCorrection.vue - updated unit tests --------- Co-authored-by: Severin Beauvais <[email protected]>
JazzarKarim · Jul 2, 2024 · 95e6d8b · 95e6d8b
1 parent 97def4b
commit 95e6d8b
Show file tree

Hide file tree

Showing 108 changed files with 1,123 additions and 496 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "business-edit-ui",
-  "version": "4.10.1",
+  "version": "4.10.2",
   "private": true,
   "appName": "Edit UI",
   "sbcName": "SBC Common Components",
@@ -23,7 +23,7 @@
     "@bcrs-shared-components/completing-party": "2.1.30",
     "@bcrs-shared-components/confirm-dialog": "1.2.1",
     "@bcrs-shared-components/contact-info": "1.2.5",
-    "@bcrs-shared-components/corp-type-module": "1.0.11",
+    "@bcrs-shared-components/corp-type-module": "1.0.16",
     "@bcrs-shared-components/court-order-poa": "2.1.3",
     "@bcrs-shared-components/date-picker": "1.2.5",
     "@bcrs-shared-components/detail-comment": "1.1.3",

diff --git a/src/App.vue b/src/App.vue
@@ -166,7 +166,7 @@ export default class App extends Mixins(CommonMixin, FilingTemplateMixin) {
     confirm: ConfirmDialogType
   }
 
-  // Global getters
+  // Store getters
   @Getter(useStore) getAppValidate!: boolean
   @Getter(useStore) getComponentValidate!: boolean
   @Getter(useStore) getCurrentJsDate!: Date
@@ -187,7 +187,7 @@ export default class App extends Mixins(CommonMixin, FilingTemplateMixin) {
   @Getter(useStore) isSummaryMode!: boolean
   @Getter(useStore) showFeeSummary!: boolean
 
-  // Global actions
+  // Store actions
   @Action(useStore) setAccountInformation!: (x: AccountInformationIF) => void
   @Action(useStore) setAppValidate!: (x: boolean) => void
   @Action(useStore) setBusinessId!: (x: string) => void

diff --git a/src/components/Alteration/AlterationSummary.vue b/src/components/Alteration/AlterationSummary.vue
@@ -188,7 +188,7 @@ import { useStore } from '@/store/store'
   }
 })
 export default class AlterationSummary extends Mixins(DateMixin, FeeMixin, FilingTemplateMixin) {
-  // Global getters
+  // Store getters
   @Getter(useStore) getBusinessNumber!: string
   @Getter(useStore) getCurrentFees!: FeesIF[]
   @Getter(useStore) getFlagsReviewCertify!: FlagsReviewCertifyIF
@@ -198,7 +198,7 @@ export default class AlterationSummary extends Mixins(DateMixin, FeeMixin, Filin
   @Getter(useStore) haveNewResolutionDates!: boolean
   @Getter(useStore) isBusySaving!: boolean
 
-  // Global actions
+  // Store actions
   @Action(useStore) setEffectiveDateValid!: (x: boolean) => void
 
   /** Whether to perform validation. */

diff --git a/src/components/Alteration/Articles/Articles.vue b/src/components/Alteration/Articles/Articles.vue
@@ -58,7 +58,7 @@ export default class Articles extends Mixins(CommonMixin) {
   private isEditingCompanyProvisions = false
   private isAddingResolutionDate = false
 
-  // Global getters
+  // Store getters
   @Getter(useStore) getBusinessInformation!: BusinessInformationIF
   @Getter(useStore) getNewResolutionDates!: string[]
   @Getter(useStore) areProvisionsRemoved!: boolean
@@ -68,7 +68,7 @@ export default class Articles extends Mixins(CommonMixin) {
   @Getter(useStore) getComponentValidate!: boolean
   @Getter(useStore) isAlterationFiling!: boolean
 
-  // Global actions
+  // Store actions
   @Action(useStore) setProvisionsRemoved!: (x: boolean) => void
   @Action(useStore) setNewResolutionDates!: (x: string[]) => void
   @Action(useStore) setValidComponent!: (x: ActionKvIF) => void

diff --git a/src/components/Alteration/Articles/ResolutionDates.vue b/src/components/Alteration/Articles/ResolutionDates.vue
@@ -197,7 +197,7 @@ export default class ResolutionDates extends Mixins(CommonMixin, DateMixin) {
   /** Boolean indicating rights or restrictions in ShareStructure. */
   @Prop({ default: false }) readonly hasRightsOrRestrictions!: boolean
 
-  // Global getters
+  // Store getters
   @Getter(useStore) getBusinessFoundingDateTime!: string
   @Getter(useStore) getCurrentDate!: string
   @Getter(useStore) haveNewResolutionDates!: boolean

diff --git a/src/components/Alteration/BcRegEntityDetails.vue b/src/components/Alteration/BcRegEntityDetails.vue
@@ -1,6 +1,6 @@
 <template>
   <div>
-    <template v-if="isBenefit">
+    <template v-if="isBenefitCompany">
       <div class="my-6">
         <p class="subtitle">
           {{ updatedArticleTitle }}
@@ -240,7 +240,7 @@ import { ResourceUtilities } from '@/utils'
 })
 export default class BcRegEntityDetails extends Vue {
   @Prop({ default: false }) readonly confirmArticles!: boolean
-  @Prop({ default: false }) readonly isBenefit!: boolean
+  @Prop({ default: false }) readonly isBenefitCompany!: boolean
   @Prop({ default: false }) readonly isUnlimitedLiability!: boolean
   @Prop({ default: false }) readonly isCommunityContribution!: boolean
   @Prop({ default: false }) readonly isBcLimited!: boolean

diff --git a/src/components/Alteration/index.ts b/src/components/Alteration/index.ts
@@ -1,4 +1,3 @@
 export * from './Articles'
 export { default as AlterationSummary } from './AlterationSummary.vue'
-export { default as BcRegEntityDetails } from './BcRegEntityDetails.vue'
 export { default as HelpSectionToggle } from './HelpSectionToggle.vue'
diff --git a/src/components/Alteration/summary/BusinessType.vue b/src/components/Alteration/summary/BusinessType.vue
@@ -45,6 +45,9 @@ import { ResourceUtilities } from '@/utils/resource-utils'
 export default class BusinessType extends Mixins(FilingTemplateMixin) {
   readonly GetCorpFullDescription = GetCorpFullDescription // for template
 
+  // Store getters
+  // @Getter(useStore) getOriginalLegalType!: CorpTypeCd
+
   get articleInfo (): string {
     return ResourceUtilities.articleInfo(this.getEntityType)
   }

diff --git a/src/components/Change/ChangeSummary.vue b/src/components/Change/ChangeSummary.vue
@@ -91,7 +91,7 @@
             cols="12"
             sm="3"
           >
-            <label>{{ isSoleProp ? 'Proprietor' : 'Partner' }} Information</label>
+            <label>{{ isEntitySoleProp ? 'Proprietor' : 'Partner' }} Information</label>
           </v-col>
         </v-row>
         <v-row
@@ -125,7 +125,7 @@ import { useStore } from '@/store/store'
   }
 })
 export default class ChangeSummary extends Vue {
-  // Global getters
+  // Store getters
   @Getter(useStore) getBusinessNumber!: string
   @Getter(useStore) getCurrentNaics!: NaicsIF
   @Getter(useStore) getNameRequestLegalName!: string
@@ -134,7 +134,7 @@ export default class ChangeSummary extends Vue {
   @Getter(useStore) hasNaicsChanged!: boolean
   @Getter(useStore) haveOfficeAddressesChanged!: boolean
   @Getter(useStore) havePeopleAndRolesChanged!: boolean
-  @Getter(useStore) isSoleProp!: boolean
+  @Getter(useStore) isEntitySoleProp!: boolean
 
   /** Whether to perform validation. */
   @Prop() readonly validate!: boolean

diff --git a/src/components/Conversion/ConversionSummary.vue b/src/components/Conversion/ConversionSummary.vue
@@ -60,7 +60,7 @@
             cols="12"
             sm="3"
           >
-            <label>{{ isSoleProp ? 'Proprietor' : 'Partner' }} Information</label>
+            <label>{{ isEntitySoleProp ? 'Proprietor' : 'Partner' }} Information</label>
           </v-col>
         </v-row>
         <v-row
@@ -95,12 +95,12 @@ import { useStore } from '@/store/store'
   }
 })
 export default class ConversionSummary extends Vue {
-  // Global getters
+  // Store getters
+  @Getter(useStore) getCurrentNaics!: NaicsIF
   @Getter(useStore) hasNaicsChanged!: boolean
   @Getter(useStore) haveOfficeAddressesChanged!: boolean
   @Getter(useStore) havePeopleAndRolesChanged!: boolean
-  @Getter(useStore) getCurrentNaics!: NaicsIF
-  @Getter(useStore) isSoleProp!: boolean
+  @Getter(useStore) isEntitySoleProp!: boolean
 
   /** Whether to perform validation. */
   @Prop() readonly validate!: boolean

diff --git a/src/components/Restoration/RestorationSummary.vue b/src/components/Restoration/RestorationSummary.vue
@@ -51,7 +51,7 @@ import { useStore } from '@/store/store'
   }
 })
 export default class RestorationSummary extends Mixins(DateMixin, FeeMixin, FilingTemplateMixin) {
-  // Global getters
+  // Store getters
   @Getter(useStore) getBusinessNumber!: string
   @Getter(useStore) getCurrentFees!: FeesIF[]
   // @Getter(useStore) getNameRequestLegalName!: string

diff --git a/src/components/SpecialResolution/SpecialResolutionSummary.vue b/src/components/SpecialResolution/SpecialResolutionSummary.vue
@@ -138,7 +138,7 @@ import { useStore } from '@/store/store'
   }
 })
 export default class SpecialResolutionSummary extends Mixins(DateMixin, FeeMixin, FilingTemplateMixin) {
-  // Global getters
+  // Store getters
   @Getter(useStore) getBusinessNumber!: string
   @Getter(useStore) getCurrentFees!: FeesIF[]
   // @Getter(useStore) getNameRequestLegalName!: string

diff --git a/src/components/ViewWrapper.vue b/src/components/ViewWrapper.vue
@@ -95,7 +95,7 @@ export default class ViewWrapper extends Mixins(CommonMixin, FilingTemplateMixin
     confirm: ConfirmDialogType
   }
 
-  // Global getters
+  // Store getters
   // @Getter(useStore) getCurrentJsDate!: Date
   @Getter(useStore) getAppValidate!: boolean
   @Getter(useStore) getComponentValidate!: boolean
@@ -117,7 +117,7 @@ export default class ViewWrapper extends Mixins(CommonMixin, FilingTemplateMixin
   @Getter(useStore) isSpecialResolutionFiling!: boolean
   @Getter(useStore) showFeeSummary!: boolean
 
-  // Global actions
+  // Store actions
   @Action(useStore) setAppValidate!: (x: boolean) => void
   @Action(useStore) setComponentValidate!: (x: boolean) => void
   @Action(useStore) setHaveUnsavedChanges!: (x: boolean) => void

diff --git a/src/components/common/Actions.vue b/src/components/common/Actions.vue
@@ -72,7 +72,7 @@ import { useStore } from '@/store/store'
 /** This component is only implemented for Correction filings atm. */
 @Component({})
 export default class Actions extends Mixins(DateMixin, FilingTemplateMixin, NameRequestMixin) {
-  // Global getters
+  // Store getters
   @Getter(useStore) getFilingId!: number
   // @Getter(useStore) getNameRequestNumber!: string
   @Getter(useStore) hasAlterationDataChanged!: boolean // for testing state-getters
@@ -85,7 +85,7 @@ export default class Actions extends Mixins(DateMixin, FilingTemplateMixin, Name
   @Getter(useStore) isSaving!: boolean
   @Getter(useStore) isSavingResuming!: boolean
 
-  // Global actions
+  // Store actions
   @Action(useStore) setIsSaving!: (x: boolean) => void
   @Action(useStore) setIsSavingResuming!: (x: boolean) => void
   @Action(useStore) setIsFilingPaying!: (x: boolean) => void

diff --git a/src/components/common/DocumentsDelivery.vue b/src/components/common/DocumentsDelivery.vue
@@ -93,7 +93,7 @@ import { useStore } from '@/store/store'
 
 @Component({})
 export default class DocumentsDelivery extends Mixins(CommonMixin) {
-  // Global getters
+  // Store getters
   @Getter(useStore) getUserEmail!: string
   @Getter(useStore) getBusinessContact!: ContactPointIF
   @Getter(useStore) isRoleStaff!: boolean
@@ -102,7 +102,7 @@ export default class DocumentsDelivery extends Mixins(CommonMixin) {
   @Getter(useStore) getFilingName!: FilingNames
   @Getter(useStore) getResource!: ResourceIF
 
-  // Global actions
+  // Store actions
   @Action(useStore) setDocumentOptionalEmail!: (x: string) => void
   @Action(useStore) setDocumentOptionalEmailValidity!: (x: boolean) => void
 

diff --git a/src/components/common/EntityInfo.vue b/src/components/common/EntityInfo.vue
@@ -56,7 +56,7 @@ import { useStore } from '@/store/store'
 
 @Component({})
 export default class EntityInfo extends Mixins(CommonMixin) {
-  // Global getters
+  // Store getters
   @Getter(useStore) getBusinessId!: string
   @Getter(useStore) getBusinessInformation!: BusinessInformationIF
   @Getter(useStore) getOriginalLegalType!: CorpTypeCd

diff --git a/src/components/common/PeopleAndRoles/CurrentDirectors.vue b/src/components/common/PeopleAndRoles/CurrentDirectors.vue
@@ -107,7 +107,7 @@ export default class CurrentDirectors extends Mixins(CommonMixin) {
   readonly RoleTypes = RoleTypes
   readonly IsSame = IsSame
 
-  // Global getters
+  // Store getters
   @Getter(useStore) getOrgPeople!: OrgPersonIF[]
 
   /** Headers for the person table. */

diff --git a/src/components/common/PeopleAndRoles/ListPeopleAndRoles.vue b/src/components/common/PeopleAndRoles/ListPeopleAndRoles.vue
@@ -568,7 +568,7 @@ export default class ListPeopleAndRoles extends Mixins(CommonMixin, OrgPersonMix
   @Getter(useStore) getOrgPeople!: OrgPersonIF[]
   @Getter(useStore) hideChangeButtonForSoleProps!: boolean
   @Getter(useStore) isAlterationFiling!: boolean
-  @Getter(useStore) isBenBcCccUlcCorrectionFiling!: boolean
+  @Getter(useStore) isBaseCorrectionFiling!: boolean
   @Getter(useStore) isCoopCorrectionFiling!: boolean
   @Getter(useStore) isCorrectionFiling!: boolean
   @Getter(useStore) isFirmChangeFiling!: boolean
@@ -628,7 +628,7 @@ export default class ListPeopleAndRoles extends Mixins(CommonMixin, OrgPersonMix
     if (this.isFirmConversionFiling) {
       return true
     }
-    if (this.isBenBcCccUlcCorrectionFiling) {
+    if (this.isBaseCorrectionFiling) {
       return true
     }
     if (this.isCoopCorrectionFiling) {