Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vagrant is already running install.sh as root, so the "sudo"s inside of it are unnecessary.
See:
http://docs.vagrantup.com/v2/provisioning/shell.html
Specifically, the "privileged" attribute, which in your Vagrantfile, is not set, and therefore defaulted to "true":
And to be absolutely certain, you can add "whoami >> whoami.log" anywhere inside your install.sh script, and you can see it is "root". This is likely how you're already able to modify your config files without sudo.
And thanks Jeffrey for all that you do... I'm a big fan. :)