Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unnecessary sudos #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Removed unnecessary sudos #14

wants to merge 1 commit into from

Conversation

jdunk
Copy link

@jdunk jdunk commented Jun 9, 2014

Vagrant is already running install.sh as root, so the "sudo"s inside of it are unnecessary.

See:

http://docs.vagrantup.com/v2/provisioning/shell.html

Specifically, the "privileged" attribute, which in your Vagrantfile, is not set, and therefore defaulted to "true":

privileged (boolean) - Specifies whether to execute the shell script as a privileged user or not (sudo). By default this is "true".

And to be absolutely certain, you can add "whoami >> whoami.log" anywhere inside your install.sh script, and you can see it is "root". This is likely how you're already able to modify your config files without sudo.

And thanks Jeffrey for all that you do... I'm a big fan. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant