Write tests for NestedFilteredAggregation

Jeroen-G · Apr 25, 2024 · dbd766c · dbd766c
1 parent fb90b9b
commit dbd766c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/Application/Results.php b/src/Application/Results.php
@@ -34,7 +34,7 @@ public function aggregations(): array
 
         foreach ($this->rawResults['aggregations'] as $name => $rawAggregation) {
             if (array_key_exists('doc_count', $rawAggregation)) {
-                $aggregations = array_merge($aggregations, $this->parseNestedAggregation($rawAggregation));
+                $aggregations = array_merge($aggregations, $this->parseNestedAggregations($rawAggregation));
                 continue;
             }
 
@@ -50,7 +50,7 @@ public function count(): int
     }
 
     /** @return AggregationResult[] */
-    private function parseNestedAggregation(array $rawAggregation): array {
+    private function parseNestedAggregations(array $rawAggregation): array {
         $aggregations = [];
         if (array_key_exists('doc_count', $rawAggregation)) {
             foreach ($rawAggregation as $nestedAggregationName => $rawNestedAggregation) {
@@ -59,7 +59,7 @@ private function parseNestedAggregation(array $rawAggregation): array {
                 }
 
                 if(is_array($rawNestedAggregation)) {
-                    $aggregations = array_merge($aggregations, $this->parseNestedAggregation($rawNestedAggregation));
+                    $aggregations = array_merge($aggregations, $this->parseNestedAggregations($rawNestedAggregation));
                 }
             }
         }

diff --git a/src/Domain/Aggregations/NestedFilteredAggregation.php b/src/Domain/Aggregations/NestedFilteredAggregation.php
@@ -34,7 +34,7 @@ public function __construct(string $path, string $name, string $field, array $fi
     /**
      * @return array<string, mixed>
      */
-    public function buildElasticFilters(): array
+    private function buildElasticFilters(): array
     {
         $elasticFilters = [];
         foreach ($this->filters as $field => $filterValues) {