allow custom order by

[Ar0010r]

Some people might wanna use more complex order by statements like this:

"sort": [
{
"prices.value": {
"order": "desc",
"nested": {
"path": "prices",
"filter": {
"term": {
"prices.shop_id": "6f8c648c-112e-43ad-a93d-7ca72ea90aee"
}
}
}
}
}
]

So I think it wise to allow adding SyntaxInterface objects to the ScoutSearchCommandBuilder's $sort array, and not just Sort objects.

Thanks

[Jeroen-G]

Does Elastic support all types of queries in a sort?

[Ar0010r]

not sure about all types of queries, but some of them it certainly accepts. Using this feature in my current project.

Also, I have fixed failing tests.
Locally i have : OK (205 tests, 330 assertions), after I run "vendor/bin/phpunit"

Thanks for the answer

[Jeroen-G]

This change allows all queries, if it's only a few I'd rather have it typed more strictly.

Thanks for contributing btw!

[Jeroen-G]

Can you find a list of the allowed queries?

[Ar0010r]

I have checked the list of allowed options in sort section, and after my research I dont think that its possible to create one interface that will cover all cases.

Here is the list : https://www.elastic.co/guide/en/elasticsearch/reference/current/sort-search-results.html

So I think that we can stick with SyntaxInterface solution.

What do you think about it ?

[Jeroen-G]

Oh boy there are some funky things.
Yeah let's stick with this.

Regarding your tests: phpunit is only for the unit tests, there is also infection PHP for mutation tests and those fail.

[Jeroen-G]

make mutations and make tests

[Ar0010r]

Im working on fixing mutations, just dont know how to proceed. Investigating

[Jeroen-G]

It usually means a case is not tested.

[Ar0010r]

Hello again ! I was able to adjust test so infection runs with no errors
Please take a look once you available

Thanks

[artemsky]

Nested sort ability was broken by this PR :( #217