-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Elasticsearch ^8.0 support #239
base: master
Are you sure you want to change the base?
Conversation
bumb es version
Whoah, you have put in a good amount of work! Thanks, I have approved the CI actions to run and give you some feedback and I will review the code asap. |
Re: the CI failures, check out the Makefile which can possibly fix the codestyle (and run the tests etc.) for you. |
@Jeroen-G I have been working on updating this PR to get 8.x into the lib. A few things related to CI, looks like there will need to be an update to a fair bit more as the Long story short, would you rather I create a PR into this PR, or just have a fresh PR (with these initial changes in it and the new adjustments)? |
This pull request contains breaking changes.
Elasticsearch 8.x introduced many breaking changes to the client. It seems to have been a complete overhaul.
8.x also introduced the ClientInterface so there is no longer a need for the following files:
and associated tests:
Client can now be injected via ClientInterface so ElasticClientBuilder was replaced with Elastic's native ClientBuilder and documentation has been updated to reflect this.