Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get CURL_VERIFY param from config() instead of env() #90

Merged
merged 4 commits into from
Oct 30, 2019
Merged

Get CURL_VERIFY param from config() instead of env() #90

merged 4 commits into from
Oct 30, 2019

Conversation

zlodes
Copy link
Contributor

@zlodes zlodes commented Oct 29, 2019

When Laravel configs are cached (php artisan config:cache), any env(..) calls will return null instead of correct value.

Reference: https://stackoverflow.com/a/53385384

Jeroen-G
Jeroen-G requested changes Oct 30, 2019
View reviewed changes
Copy link
Owner

@Jeroen-G Jeroen-G left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I really like that it will be a config setting and not an env variable.

src/FileHandler.php Outdated Show resolved Hide resolved
config/packager.php Show resolved Hide resolved
@zlodes zlodes requested a review from Jeroen-G October 30, 2019 17:06
@Jeroen-G Jeroen-G merged commit 5970ee1 into Jeroen-G:master Oct 30, 2019
@zlodes zlodes deleted the fix-env-config branch October 31, 2019 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jeroen-G Jeroen-G Jeroen-G approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zlodes @Jeroen-G