Add Softmax-13 #158
Open
Add Softmax-13 #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per https://github.com/onnx/onnx/blob/main/docs/Changelog.md#Softmax-13
Context: These changes allow me to run OpenCLIP models with kinference.
Potentially unaccounted differences:
I am low confidence, but I think the difference with the Axis attribute in Softmax-13 vs earlier versions is actually just an implementation detail, and doesn't actually impact output/input?
Another difference is that Softmax-13 is supposed to support BFLOAT, again low confidence, but I think that also requires no changes here?
Lastly there is Differentiability, which doesn't matter so much because this library is for inference?