Animate compose content size transitions #1691
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatkovIvan
reviewed
Nov 13, 2024
Comment on lines
24
to
28
| internal fun easeInOutTimingFunction(progress: Float) = if (progress < 0.5) { | ||
| 2 * progress * progress | ||
| } else { | ||
| (-2 * progress * progress) + (4 * progress) - 1 | ||
| } |
There was a problem hiding this comment.
Mixing ints, doubles and floats. Let's align that
| @@ -88,14 +88,29 @@ internal class ComposeHostingViewController( | |||
| private val lifecycleOwner = ViewControllerBasedLifecycleOwner() | |||
| private val hapticFeedback = CupertinoHapticFeedback() | |||
|
|
|||
| private val metalView = MetalView( | |||
There was a problem hiding this comment.
It is not clear what view it is. for the initial mediator? for Popups?
There was a problem hiding this comment.
Renamed to rootMetalView
| @@ -243,7 +232,7 @@ internal class ComposeSceneMediator( | |||
| /** | |||
| * View wrapping the hierarchy managed by this Mediator. | |||
| */ | |||
| private val view = ComposeSceneMediatorView( | |||
| val view = ComposeSceneMediatorView( | |||
| @@ -64,7 +62,7 @@ internal class UIKitComposeSceneLayer( | |||
| isInterceptingOutsideEvents = { focusable } | |||
| ) | |||
|
|
|||
| private val mediator = ComposeSceneMediator( | |||
| val mediator = ComposeSceneMediator( | |||
| right = size.width, | ||
| bottom = size.height, | ||
| right = Float.MAX_VALUE, | ||
| bottom = Float.MAX_VALUE, |
There was a problem hiding this comment.
Why was it changed? Did it affect the performance?
There was a problem hiding this comment.
During the animation, canvas can be greater than layer's view. And because of aync scene updates. schirm may have glitches on edges.
This solution does not degrade performance, but I found another one with getting bounds of MetalView, PTAL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Animate the size transition of Compose scenes and platform windows when the size of the ComposeUIViewController changes.
Example: https://github.com/user-attachments/assets/0054014c-fc8e-419d-8ffb-eaf6497dfb5e
Fixes https://youtrack.jetbrains.com/issue/CMP-1491/Fix-interop-views-animation-while-rotating-screen
Testing
Features - iOS