Fix configuration cache for syncComposeResourcesForIos
#3764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Configuration cache state could not be cached: field `resourceFiles` of task `:shared:syncComposeResourcesForIos` of type `org.jetbrains.compose.experimental.uikit.tasks.SyncComposeResourcesForIosTask`: error writing value of type 'org.gradle.api.internal.provider.TransformBackedProvider'
pjBooms
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when
org.gradle.configuration-cache=truewe have an error:Old description (can be ignored):
This PR attempts to fix it in SyncComposeResourcesForIosTask by wrapping inputs into providers. It seems that gradle configuration cache doesn't like some provider types produced by
.map,.zip,.orElse, etc.Latest description:
With configuration cache enabled, gradle runs all
orElseproviders during configuration (I don't know why yet).We used to throw an exception in
orElsewhich led to the crash. This PR refactors SyncComposeResourcesForIosTask so it doesn't throw an exception immediately in orElse, but postpones it to later step.