Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for versions lower than Gradle 8.0 #5177

Closed
wants to merge 4 commits into from

Conversation

Omico
Copy link
Contributor

@Omico Omico commented Dec 9, 2024

Since Compose Multiplatform 1.7.1, the minimum AGP version has been raised to 8.1.0. This means the minimum Gradle version is 8.0. Thus, we can safely remove this function.
https://www.jetbrains.com/help/kotlin-multiplatform-dev/whats-new-compose-170.html#minimum-agp-version-raised-to-8-1-0
https://developer.android.com/build/releases/past-releases/agp-8-1-0-release-notes

@MatkovIvan MatkovIvan requested a review from terrakok December 9, 2024 10:22
@Omico
Copy link
Contributor Author

Omico commented Dec 9, 2024

@terrakok, I need some help. Is this still relevant? This prevents compilation, if we raise the Kotlin language version to 1.8.

/**
* Gradle runtime verification fails,
* if InputDirectory is not null, but a directory does not exist.
* The directory might not exist, because prepareAppResources task
* does not create output directory if there are no resources.
*
* To work around this, appResourcesDir is used as a real property,
* but it is annotated as @Internal, so it ignored during inputs checking.
* This property is used only for inputs checking.
* It returns appResourcesDir value if the underlying directory exists.
*/
@Suppress("unused")
@get:InputDirectory
@get:Optional
internal val appResourcesDirInputDirHackForVerification: Provider<Directory>
get() = appResourcesDir.map { it.takeIf { it.asFile.exists() } }

@terrakok
Copy link
Member

the minimum AGP version has been raised to 8.1.0. This means the minimum Gradle version is 8.0.

Projects with no android still may use Gradle 7.1

@terrakok terrakok closed this Dec 10, 2024
@Omico Omico deleted the plugin branch December 30, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants