[#135] Create nodes for cells with zero lengths #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here
GitHubTableMarkerBlock#fillCellsnodes for cells and separators are created. And a node for a cell is created even if its length is zero.And then here
TreeBuilder#constructEventsevents are created, and for nodes with zero lengths, only one event is created (and not two as elsewhere). And then after sorting, these events are strangely located. Such a cell appears to be between the opening and closing of the separator.Therefore, I think that it is necessary to correct how these events are compared, specifically in the case of an empty event.