Add wasmJs target #151
Merged
Add wasmJs target #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajalt
commented
Feb 29, 2024
| @@ -21,7 +21,6 @@ actual fun isWhitespace(char: Char): Boolean { | |||
| return char == 0.toChar() || char.isWhitespace() | |||
| } | |||
|
|
|||
| @SharedImmutable | |||
There was a problem hiding this comment.
SharedImmutable isn't defined on the wasm target, but it's been a deprecated no-op since 1.9.0 anyway, so there's no harm in removing them.
ajalt
commented
Feb 29, 2024
| @@ -66,6 +71,11 @@ kotlin { | |||
| ios() | |||
|
|
|||
| sourceSets { | |||
| all { | |||
| languageSettings { | |||
| optIn("kotlin.experimental.ExperimentalNativeApi") | |||
There was a problem hiding this comment.
This is a new opt in requirement added in 1.9.20. We only use a function it applies to in one place in the nativeTest source set, but since the compile language version is 1.7 and this annotation didn't exist in 1.7, we have to opt in as a compiler argument.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This required bumping Kotlin to
1.9.22for the newwasmJstarget.